Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable cmake color output for clang/ninja #1287

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Enable cmake color output for clang/ninja #1287

merged 2 commits into from
Oct 28, 2024

Conversation

janbridley
Copy link
Contributor

@janbridley janbridley commented Oct 25, 2024 •
edited
Loading

As in ninja-build/Ninja's FAQ, cmake does not color output for build systems that buffer output. The code added in this PR fixes this

How Has This Been Tested?

CMake colors output with the changes made, and does not without.

Before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@janbridley janbridley marked this pull request as ready for review October 25, 2024 16:58
@janbridley janbridley requested a review from a team as a code owner October 25, 2024 16:58
@janbridley janbridley requested review from Lina492375qW1188 and joaander and removed request for a team October 25, 2024 16:58
@janbridley janbridley self-assigned this Oct 25, 2024
joaander
joaander approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joaander joaander merged commit d0850af into main Oct 28, 2024
15 checks passed
@joaander joaander deleted the cmake-color branch October 28, 2024 12:19
@joaander
Copy link
Member

Merged up into nanobind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaander joaander joaander approved these changes

@Lina492375qW1188 Lina492375qW1188 Awaiting requested review from Lina492375qW1188 Lina492375qW1188 is a code owner automatically assigned from glotzerlab/freud-developers

Assignees

@janbridley janbridley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janbridley @joaander